Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 Fix docker & Move from Redis to Valkey #358

Merged
merged 1 commit into from
Apr 13, 2024
Merged

🚑 Fix docker & Move from Redis to Valkey #358

merged 1 commit into from
Apr 13, 2024

Conversation

rflihxyz
Copy link
Contributor

@rflihxyz rflihxyz commented Apr 13, 2024

Summary by CodeRabbit

  • New Features

    • Introduced GitHub Actions workflows for compiling Docker images for backend and frontend applications in a self-hosted environment.
  • Refactor

    • Changed Docker images and tags for backend API, Redis, and frontend services to support self-hosted configurations.
  • Chores

    • Modified GitHub Actions workflow to trigger only on push events to the main branch, removing the pull_request trigger.

Copy link

changeset-bot bot commented Apr 13, 2024

⚠️ No Changeset found

Latest commit: 41518ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
panora-client-ts ❌ Failed (Inspect) Apr 13, 2024 5:51pm

Copy link
Contributor

coderabbitai bot commented Apr 13, 2024

Walkthrough

The recent updates focus on refining Docker workflows and images for a self-hosted environment. Changes include new GitHub Actions workflows for building Docker images on pull requests, adjustments to Docker Compose configurations for backend and frontend services, and specific updates to Redis image versions across different environments.

Changes

Files Change Summary
.github/workflows/...docker.check-build.backend.selfhosted.yml
.github/workflows/...docker.check-build.frontend.selfhosted.yml
Introduced workflows to build and push Docker images for backend and frontend applications on pull requests to the main branch.
.github/workflows/...docker.export.backend.selfhosted.yml Modified to trigger only on push events to the main branch, removing the pull_request trigger.
docker-compose.dev.yml
docker-compose.source.yml
docker-compose.yml
Updated Redis service image to valkey/valkey:7.2-alpine and modified other service image tags towards self-hosted versions.

🐰✨
In the world of code, where Docker sails,
A rabbit hopped, updating tales.
From backend to front, changes galore,
Self-hosted dreams on the digital shore.
Cheers to the team, for changes they weave,
In the bustling burrows of GitHub's eve.
🌟🚀


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 31cf8db and 41518ac.
Files selected for processing (6)
  • .github/workflows/docker.check-build.backend.selfhosted.yml (1 hunks)
  • .github/workflows/docker.check-build.frontend.selfhosted.yml (1 hunks)
  • .github/workflows/docker.export.backend.selfhosted.yml (1 hunks)
  • docker-compose.dev.yml (1 hunks)
  • docker-compose.source.yml (1 hunks)
  • docker-compose.yml (4 hunks)
Additional comments not posted (9)
.github/workflows/docker.export.backend.selfhosted.yml (1)

4-9: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [3-7]

The workflow trigger has been correctly updated to activate only on push events to the main branch. This change should help in reducing unnecessary builds during pull requests, focusing resources on changes that are merged.

.github/workflows/docker.check-build.frontend.selfhosted.yml (1)

3-6: The workflow is set to trigger on pull_request events to the main branch, which is appropriate for ensuring that the frontend Docker images are compiled and checked before merging into the main branch.

.github/workflows/docker.check-build.backend.selfhosted.yml (1)

3-6: The workflow is set to trigger on pull_request events to the main branch, which is appropriate for ensuring that the backend Docker images are compiled and checked before merging into the main branch.

docker-compose.yml (4)

26-26: The backend-api service image has been updated to use the self-hosted tag. This change aligns with the PR's objective to move towards a self-hosted environment.


100-100: The Redis service has been replaced with Valkey, using the valkey/valkey:7.2-alpine image. This change aligns with the PR's objective to transition from Redis to Valkey for caching and session management.


110-110: The magic-link-frontend service image has been updated to use the self-hosted tag. This ensures consistency with the new deployment strategy.


123-123: The webapp-next service image has been updated to use the self-hosted tag. This update is crucial for maintaining consistency across all frontend services in the self-hosted environment.

docker-compose.source.yml (1)

104-104: The Redis service has been replaced with Valkey, using the valkey/valkey:7.2-alpine image. This change aligns with the PR's objective to transition from Redis to Valkey for caching and session management.

docker-compose.dev.yml (1)

112-112: The Redis service has been replaced with Valkey, using the valkey/valkey:7.2-alpine image. This change aligns with the PR's objective to transition from Redis to Valkey for caching and session management.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rflihxyz rflihxyz merged commit 3fb2d3d into main Apr 13, 2024
13 of 15 checks passed
@rflihxyz rflihxyz deleted the fix-docker branch April 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant