-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connectorUpdate #466
Fix connectorUpdate #466
Conversation
|
@mit-27 is attempting to deploy a commit to the Panora Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent updates primarily focus on renaming enums and file paths in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/api/scripts/connectorUpdate.js (3 hunks)
- packages/api/src/@core/utils/types/original/original.ticketing.ts (4 hunks)
Additional Context Used
Biome (38)
packages/api/scripts/connectorUpdate.js (18)
10-10: A Node.js builtin module should be imported with the node: protocol.
11-11: A Node.js builtin module should be imported with the node: protocol.
12-12: A Node.js builtin module should be imported with the node: protocol.
75-75: Template literals are preferred over string concatenation.
79-120: Prefer for...of instead of forEach.
162-197: Prefer for...of instead of forEach.
201-205: Template literals are preferred over string concatenation.
251-269: Prefer for...of instead of forEach.
253-253: Template literals are preferred over string concatenation.
260-260: This regular expression contains unclear uses of consecutive spaces.
263-263: Template literals are preferred over string concatenation.
284-284: Change to an optional chain.
295-301: Prefer for...of instead of forEach.
35-35: This let declares a variable that is only assigned once.
71-71: Reassigning a function parameter is confusing.
140-140: This let declares a variable that is only assigned once.
279-279: This let declares a variable that is only assigned once.
285-285: This let declares a variable that is only assigned once.
packages/api/src/@core/utils/types/original/original.ticketing.ts (20)
2-6: All these imports are only used as types.
6-7: All these imports are only used as types.
7-8: All these imports are only used as types.
8-12: All these imports are only used as types.
12-16: All these imports are only used as types.
16-20: All these imports are only used as types.
20-24: All these imports are only used as types.
24-28: All these imports are only used as types.
28-32: All these imports are only used as types.
32-36: All these imports are only used as types.
36-40: All these imports are only used as types.
40-44: All these imports are only used as types.
44-48: All these imports are only used as types.
48-52: All these imports are only used as types.
52-56: All these imports are only used as types.
56-60: All these imports are only used as types.
60-64: All these imports are only used as types.
64-68: All these imports are only used as types.
68-72: All these imports are only used as types.
72-76: All these imports are only used as types.
Additional comments not posted (7)
packages/api/src/@core/utils/types/original/original.ticketing.ts (4)
158-160
: LGTM! The expansion ofOriginalAccountInput
to includeZendeskAccountInput
andFrontAccountInput
enhances the flexibility of the type.
183-185
: LGTM! The addition ofJiraCollectionInput
andGitlabCollectionInput
toOriginalCollectionInput
is a positive change, increasing its utility.
224-226
: LGTM! The expansion ofOriginalAccountOutput
to includeZendeskAccountOutput
andFrontAccountOutput
is well-implemented.
256-258
: LGTM! The addition ofJiraCollectionOutput
andGitlabCollectionOutput
toOriginalCollectionOutput
broadens its applicability.packages/api/scripts/connectorUpdate.js (3)
279-279
: LGTM! The update toenumName
to useConnectors
aligns with the renaming objective of the PR.
331-331
: LGTM! The update toprovidersFilePath
to point toconnectors/index.ts
is correctly implemented.
333-333
: LGTM! The update toenumFilePath
to point toconnectors/enum.ts
is correctly implemented.
No description provided.