Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon Secrets local config #9330

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Pantheon Secrets local config #9330

merged 7 commits into from
Nov 27, 2024

Conversation

jazzsequence
Copy link
Contributor

Summary

Pantheon Secrets Guide - Updates docs for Secrets local development

Fixes #9285
Fixes #9233

@jazzsequence jazzsequence requested a review from a team as a code owner November 25, 2024 22:35
@jazzsequence jazzsequence self-assigned this Nov 25, 2024
@jazzsequence jazzsequence requested review from stovak, kporras07 and rachelwhitton and removed request for a team November 25, 2024 22:36
@jazzsequence jazzsequence added Type: Fix Content Issue or PR to resolve incorrect information in the docs Topic: Secrets labels Nov 25, 2024
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9330-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9330-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good; only 1 minor adjustment suggested

source/content/guides/secrets/07-local.md Show resolved Hide resolved

### Local Development Function

The `pantheon_get_secret()` function only works on Pantheon's infrastructure, not in local development. For local development, you can create a helper function that mimics the `pantheon_get_secret()` function. To do this, you can use the [Pantheon Customer Secrets SDK](https://github.com/pantheon-systems/customer-secrets-php-sdk). This SDK mirrors the code that is already integrated into the platform. The easiest way to install the Customer Secrets SDK locally is via Composer:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9330-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@stevector
Copy link
Contributor

With @kporras07 approval, I'm good to merge! @jazzsequence and I are going to test this section of Docs more thoroughly next week (I'll try Secrets Manager on my personal site).

@stevector stevector merged commit f76798b into main Nov 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Secrets Type: Fix Content Issue or PR to resolve incorrect information in the docs
Projects
None yet
3 participants