Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an .envrc file for testing #2534

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Adding an .envrc file for testing #2534

merged 1 commit into from
Feb 26, 2024

Conversation

stovak
Copy link
Member

@stovak stovak commented Jan 25, 2024

adding .envrc file for testing.

@stovak stovak requested a review from a team as a code owner January 25, 2024 20:16
Copy link
Member

@CobyPear CobyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@namespacebrian
Copy link
Contributor

Is there a reason to have this separate from the .env.dist that's in the root of the repo? https://github.com/pantheon-systems/terminus/blob/3.x/.env.dist

@stovak
Copy link
Member Author

stovak commented Feb 26, 2024

Is there a reason to have this separate from the .env.dist that's in the root of the repo? https://github.com/pantheon-systems/terminus/blob/3.x/.env.dist

one is for local testing and the .env.dist is for CI.

@stovak stovak merged commit 93285a2 into 3.x Feb 26, 2024
9 checks passed
@stovak stovak deleted the development-env-vars branch February 26, 2024 16:54
@namespacebrian
Copy link
Contributor

I still don't understand. CI uses secrets configured via the repo.. it doesn't use .env.dist. How is this new .env.dist used for local testing? Don't you still have to copy it to the root folder and rename it to .envrc?

namespacebrian added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants