Decoding empty body resulted in syntax error #2668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jms-pantheon
force-pushed
the
json-decode-empty
branch
from
596be08 to
902287a
Compare
jms-pantheon
force-pushed
the
json-decode-empty
branch
from
902287a to
710f113
Compare
|
Build error says: "The maximum number of Multidev environment for this service level has been reached." 😿 |
| JSON_THROW_ON_ERROR | ||
| ); | ||
| } catch (\JsonException $jsonException) { | ||
| $this->logger->debug($jsonException->getMessage()); |
There was a problem hiding this comment.
We should prepend a string in front of jsonException->getMessage() to make this line easier to find should it happen again in the future.
There was a problem hiding this comment.
100% agree, and $body should not overwrite $body on line 434. we should preserve the body before attempting json decode, and print what was in it if the json decode fails.
|
|
||
| // Don't attempt to decode JSON if the response is expected to have no body. | ||
| if ( | ||
| !in_array($statusCode, [204, 304], true) |
There was a problem hiding this comment.
It would be helpful to be more explicit (i.e., explain in a comment) the significance of these particular status codes, and why this check is important to do in addition to the content-length / empty body checks.
Comment on lines
+442
to
+445
| $body = null; | ||
| } | ||
| } else { | ||
| $body = null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when in verbose mode, Terminus would report
[debug] Syntax errorat the end of a request.When there is no body in the response, there's no need to attempt to decode it. We set it to null here.