Use existing google_request_denied.txt mock

Don't suppress any errors, please.
panthomakos · Feb 21, 2018 · 7f4626f · 7f4626f
1 parent 4bd17e2
commit 7f4626f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/lib/timezone/lookup/geonames.rb b/lib/timezone/lookup/geonames.rb
@@ -41,8 +41,6 @@ def lookup(lat, long)
         return if NO_TIMEZONE_INFORMATION == data['status']['value']
 
         raise(Timezone::Error::GeoNames, data['status']['message'])
-      rescue StandardError => e
-        raise(Timezone::Error::GeoNames, e.message)
       end
 
       private

diff --git a/lib/timezone/lookup/google.rb b/lib/timezone/lookup/google.rb
@@ -44,8 +44,6 @@ def lookup(lat, long)
         end
 
         data['timeZoneId']
-      rescue StandardError => e
-        raise(Timezone::Error::Google, e.message)
       end
 
       private

diff --git a/test/timezone/lookup/test_google.rb b/test/timezone/lookup/test_google.rb
@@ -39,7 +39,9 @@ def test_google_using_lat_long_coordinates
   end
 
   def test_google_request_denied_read_lat_long_coordinates
-    mine = lookup(nil)
+    mine = lookup(
+      File.open(mock_path + '/google_request_denied.txt').read
+    )
 
     assert_raises Timezone::Error::Google, 'The provided API key is invalid.' do
       mine.lookup(*coordinates)
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,8 +44,6 @@ def lookup(lat, long) @@
             end
             data['timeZoneId']
-          rescue StandardError => e
-            raise(Timezone::Error::Google, e.message)
           end
           private
@@ Expand Down @@