resolve pants plugins using direct pex invocations
#21986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
category:internal
|
Back to draft while I figure out why this works locally but not in CI. |
|
Fixed that issue in CI. Ready for review again. |
tdyas
commented
Feb 21, 2025
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class PexCli(TemplatedExternalTool): |
There was a problem hiding this comment.
Moved this class to pex_cli_tool.py so that plugin resolution could depend directly on the Pex download rules.
| from pants.util.logging import LogLevel | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| @dataclass(frozen=True) |
There was a problem hiding this comment.
Vendored these two classes and function from VenvScriptWriter to avoid the dependency on Python backend.
|
Does this PR introduce any numerical perf differences? |
I haven't measured yet since I'm still working through its correctness given the test failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of implementing #21985 to reduce the scope of the bootstrap scheduler, modify the plugin resolution rules to invoke
pexdirectly without using any of the Pex machinery in the Python backend (e.g.,CompletePexEnvironentand other support classes). This should permit future work to remove the Python backend from the bootstrap scheduler.The plugin does consume a few subsystems from the Python backend for configuration, but no rule logic aside from the
PexClidownload logic which has been moved to its own file.The direct
pexcalls are based on the calls performed forVenvPex-style internal venv pex files.