Fix defective jquery.cookie invocation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The $.cookie function expects the `domain`, `expires` and `path` options as one object as the third parameter, not as individual parameters. * The `domain` option should be left empty when the cookie is set for the current domain. Passing `document.location.hostname` does not work always (e.g. on localhost). * Reading all cookies was introduced with jquery.cookie v1.3.0. On older websites / CMSes this feature is not available. Therefore let's just simply remove `getPermaOptions` and call jquery.cookie directly from within `getPermaOption`.
|
I use this jQuery cookie plugin: https://github.com/panzi/jQuery-Cookies (as stated in the dependencies) |
|
Oh, this is bad. Because everyone else uses http://plugins.jquery.com/cookie/ |
|
Yeah, I guess I have to switch to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
domain,expiresandpathoptions as one object as the third parameter, not as individual
parameters.
domainoption should be left empty when the cookie is setfor the current domain. Passing
document.location.hostnamedoes notwork always (e.g. on localhost).
websites / CMSes this feature is not available. Therefore let's just
simply remove
getPermaOptionsand call jquery.cookie directly fromwithin
getPermaOption.