v11 unpack integration test #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed decryption from temp files to in memory - Changed version detection to check specific footer versions - Various style and syntax improvements
This is most likely due to different footer format in higher pak versions
panzi
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Tests! Great! But how was the test data generated? I guess that should be mentioned in the test data repository. I assume using official Unreal tools, but with files that don't have any copyright issues? What are the license conditions for the official Unreal tools about generating files that are used for free?
|
Yes, I used the unreal engine to generate the test files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12
Requires #11 and #14 to be merged first
Changes from #14