Revert high dpi changes #806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikMogensen
requested review from
paolosalvatori and
SeanFeldman
as code owners
|
@ErikMogensen, could you please squash those two commits? A revert is better to be a single commit. Thanks. |
Don't you think it is enough to do it when merging it into the main branch? The end result will be same, as far as I can tell. |
|
When looking at the PRs, merged or not, they retain all the commits. When a PR is "revert", it's better to have a single commit. |
That's true. Looks like I have to abort this PR and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #804, there are some GUI things that don't look good after the changes for high DPI. Therefore this change reverts those changes.
Sorry @jmoralesv. I hope you will find the time to get this working for those scenarios.