Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple tweaks to help with local development #2083

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stldev
Copy link

@stldev stldev commented Jul 23, 2024

Description

  • In using node 20+ with corepack enabled it will write the packageManager field in the package.json file. Without that field yarn (thru corepack) might not use the correct version, but if developer does not use corepack then the field is ignored.
    image

  • Trying to get node-canvas built on m1 mac works fine with node-gyp 10+.

    • Regular "yarn" with existing node-gyp throws error
      image

    • Bump the node-gyp latest resolution to 10.2.0 and node-canvas now builds correctly
      image

  • Jsdom is important dep and it would be nice to get some newer releases for it. When I got to jsdom 20+ I was running into issues with some tests. jsdom 19 works correctly with existing tests.

Related issues

It is related to this pr = #2058 . I was struggling to get everything up and running on my m1 mac (windows was fine).

Checklist

  • New tests added or existing tests modified to cover all changes
    • existing tests cover the changes
  • Code conforms with the JSHint rules (yarn run jshint passes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants