Dawn/vale config #32
Dawn/vale config #32
Conversation
…nto dawn/vale-config
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/test.md
Outdated
|
|
||
| ### Checking Logs | ||
|
|
||
| To check the nodes’ logs, you can use the provided command listed by the output as 'Log Cmd'. For instance, to check the logs of the `alice` node, you can open a new terminal and run the following command: |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'Cmd'?
docs/test.md
Outdated
|
|
||
| ### Checking Logs | ||
|
|
||
| To check the nodes’ logs, you can use the provided command listed by the output as 'Log Cmd'. For instance, to check the logs of the `alice` node, you can open a new terminal and run the following command: |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Papermoon.CustomDictionary] Did you really mean 'Cmd'?
docs/test.md
Outdated
| This test scenario checks to verify the following: | ||
|
|
||
| - the nodes are running | ||
| - the parachain with ID 100 is registered within a certain timeframe (255 seconds in this example) |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'timeframe'?
docs/test.md
Outdated
| This test scenario checks to verify the following: | ||
|
|
||
| - the nodes are running | ||
| - the parachain with ID 100 is registered within a certain timeframe (255 seconds in this example) |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Papermoon.CustomDictionary] Did you really mean 'timeframe'?
docs/test.md
Outdated
|
|
||
| - the nodes are running | ||
| - the parachain with ID 100 is registered within a certain timeframe (255 seconds in this example) | ||
| - the parachain block height is at least a certain number within a timeframe (in this case, 10 within 255 seconds) |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'timeframe'?
docs/test.md
Outdated
|
|
||
| - the nodes are running | ||
| - the parachain with ID 100 is registered within a certain timeframe (255 seconds in this example) | ||
| - the parachain block height is at least a certain number within a timeframe (in this case, 10 within 255 seconds) |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Papermoon.CustomDictionary] Did you really mean 'timeframe'?
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| id: get-modified-files | ||
| run: | | ||
| changed_files=$(gh pr diff --name-only ${{ github.event.pull_request.number }} | grep '\.md$' || true) |
There was a problem hiding this comment.
@0xLucca, just reviewing this line, maybe worth adding support to .pages files to avoid typos there as well:
changed_files=$(gh pr diff --name-only ${{ github.event.pull_request.number }} | grep '\.md$|.pages$' || true)WDYT?
There was a problem hiding this comment.
Yeah would also like it to catch capitalization of page titles if possible
|
@eshaben I think I addressed all the comments, etc. Please let me know if you have more thoughts or requests for Vale setup. I am collecting a list of things we want it to do that aren't in place yet. |
There was a problem hiding this comment.
LGTM! On the condition we circle back and address this comment in a future PR: #32 (comment)
This PR:
Usage: Writers simply need to ensure they are using the updated main branch and then continue working with their documents as usual.
Scroll through the conversation to see examples of flagged errors.