Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing description length of some index.md files #33

Merged
merged 20 commits into from
Sep 24, 2024

Conversation

nhussein11
Copy link
Contributor

Hey there,

When running the gh action, I found that some index.md files did not meet the requirement of having a description between 120-160 characters.

This PR aims to fix those issues so that the gh run can be successful.

@eshaben
Copy link
Contributor

eshaben commented Aug 22, 2024

@nhussein11 it seems like some files from this PR are included here, but that PR is still in draft mode - do we want to release that stuff or not yet?

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catches! so excited about all of this!

docs/build-on-polkadot/parachains/index.md Outdated Show resolved Hide resolved
docs/dev-tools/zombienet/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/networks/index.md Outdated Show resolved Hide resolved
docs/networks/testnets/index.md Outdated Show resolved Hide resolved
@nhussein11
Copy link
Contributor Author

@nhussein11 it seems like some files from this PR are included here, but that PR is still in draft mode - do we want to release that stuff or not yet?

Yeah, that's correct. We can wait to merge this one until we merge that PR

Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Nico. Thanks!

@eshaben eshaben merged commit 19378d6 into main Sep 24, 2024
1 check failed
@eshaben eshaben deleted the nhussein11/fix-descriptions-length branch September 24, 2024 17:32
2. Click on the **Network** tab on the top navigation bar and select **Assets** from the dropdown list

![Access to Asset Hub through Polkadot.JS](/polkadot-ecosystem-docs-draft/images/build-on-polkadot/parachains/asset-hub/register-a-local-asset/register-a-local-asset-1.webp)
![Access to Asset Hub through Polkadot.JS](/polkadot-ecosystem-docs-draft/images/build-on-polkadot/parachains/asset-hub/register-a-local-asset/register-a-local-asset-1.webp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Google.Spacing] 't.J' should have one space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants