-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show available models list in settings #83
feat: show available models list in settings #83
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note that I have little js/ts and basically no React experience, so while this looks like it works, it might not follow best practices. |
src/components/App.tsx
Outdated
} | ||
}, [apiKey]); | ||
|
||
const isAnythingLoading = isSavingReactFlow || isSavingSettings || (availableModels === null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we should include availableModels === null
here as this is more about things being saved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like to have the spinner continue to spin until that request finishes. Added a distinction between isAnythingSaving
and isAnythingLoading
to address that.
I addressed that in the best way I could come up with, by having a hard-coded list of models to exclude. That way, usually only the stable models would be listed, but in moments like now, these additional new models show up automatically. I prefer the default to be for new versions to be shown, so app updates are only required to de-clutter, not to make new functionality accessible.
This is odd. I am unfortunately still on the waitlist for that one, so can't test myself (of course feel free to dm me an API key "for testing" 🙂). But I did see inconsistent behavior around that yesterday myself, when it briefly listed |
hmm i appreciate this but probably too much of a hassle to maintain, can just leave as is imo
dming you a 32k key via twitter so you can take a look — if its an issue on their end can always just edit the stored model json in localstorage in the meantime i guess? |
4e28bc2
to
b173691
Compare
🙏
oh weird yeah works for me as well now... 🤷
mm right gotcha. |
alright this lgtm! great work @adietrichs |
Motivation
Currently, the list of supported models is hard-coded. That has several downsides:
gpt-3.5-turbo-16k
gpt-4-0314
Solution
utils/models.ts
with agetAvailableChatModels(apiKey)
functionisAnythingLoading
Screenshot of an exemplary model list:

Checklist