Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply args-file feature to updated fork (new base) #8

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Apply args-file feature to updated fork (new base) #8

merged 1 commit into from
Dec 13, 2022

Conversation

gbhand
Copy link
Collaborator

@gbhand gbhand commented Dec 13, 2022

Background

Duplicate of #7 from correct base

Once #6 is merged, the args-file feature should be re-applied to this repo.

Description

  • Adds existing args-file code adapted for Node 16

Verification

Confirmed clippy runs and produces annotations in test repo

@gbhand gbhand requested a review from joshparallel December 13, 2022 16:01
@gbhand gbhand self-assigned this Dec 13, 2022
@gbhand gbhand mentioned this pull request Dec 13, 2022
Closed
joshparallel
joshparallel approved these changes Dec 13, 2022
View reviewed changes
Copy link

@joshparallel joshparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbhand gbhand merged commit 5a7a17c into main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshparallel joshparallel joshparallel approved these changes

Assignees

@gbhand gbhand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbhand @joshparallel