Skip to content

Commit

Permalink
Add PHP 8.4 support for 7.4.x (#899)
Browse files Browse the repository at this point in the history
  • Loading branch information
Slamdunk authored Oct 15, 2024
1 parent 7057394 commit cf16fcb
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 17 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
tools: composer-normalize, composer-require-checker
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- run: "composer validate --strict"
- run: "composer-normalize --dry-run"
Expand All @@ -48,7 +48,7 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- name: "Lint XMLs"
uses: ./.github/lint-xml-configuration
Expand All @@ -64,6 +64,7 @@ jobs:
php-version:
- "8.2"
- "8.3"
- "8.4"
dependencies:
- "lowest"
- "highest"
Expand All @@ -75,7 +76,7 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"
with:
dependency-versions: "${{ matrix.dependencies }}"

Expand All @@ -98,7 +99,7 @@ jobs:
# coverage: "pcov"
# php-version: "${{ matrix.php-version }}"
# ini-values: "${{ env.INI_VALUES }}"
# - uses: "ramsey/composer-install@v2"
# - uses: "ramsey/composer-install@v3"
#
# - name: "Gather base branch for diff"
# if: ${{ github.event_name == 'pull_request' }}
Expand Down Expand Up @@ -134,7 +135,7 @@ jobs:
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
tools: cs2pr
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- run: "vendor/bin/phpcs -q --report=checkstyle | cs2pr"

Expand All @@ -153,6 +154,6 @@ jobs:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: "${{ env.INI_VALUES }}"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"

- run: "vendor/bin/phpstan --memory-limit=512M --ansi --no-progress"
18 changes: 9 additions & 9 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}
],
"require": {
"php": "~8.2.0 || ~8.3.0",
"php": "~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-dom": "*",
"ext-pcre": "*",
"ext-reflection": "*",
Expand All @@ -43,21 +43,21 @@
"phpunit/php-code-coverage": "^10.1.16",
"phpunit/php-file-iterator": "^4.1.0",
"phpunit/php-timer": "^6.0.0",
"phpunit/phpunit": "^10.5.33",
"phpunit/phpunit": "^10.5.36",
"sebastian/environment": "^6.1.0",
"symfony/console": "^6.4.7 || ^7.1.4",
"symfony/process": "^6.4.7 || ^7.1.3"
"symfony/console": "^6.4.7 || ^7.1.5",
"symfony/process": "^6.4.7 || ^7.1.5"
},
"require-dev": {
"ext-pcov": "*",
"ext-posix": "*",
"doctrine/coding-standard": "^12.0.0",
"phpstan/phpstan": "^1.12.3",
"phpstan/phpstan-deprecation-rules": "^1.2.0",
"phpstan/phpstan": "^1.12.6",
"phpstan/phpstan-deprecation-rules": "^1.2.1",
"phpstan/phpstan-phpunit": "^1.4.0",
"phpstan/phpstan-strict-rules": "^1.6.0",
"squizlabs/php_codesniffer": "^3.10.2",
"symfony/filesystem": "^6.4.3 || ^7.1.2"
"phpstan/phpstan-strict-rules": "^1.6.1",
"squizlabs/php_codesniffer": "^3.10.3",
"symfony/filesystem": "^6.4.3 || ^7.1.5"
},
"autoload": {
"psr-4": {
Expand Down
4 changes: 2 additions & 2 deletions test/Unit/WrapperRunner/WrapperRunnerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public function testTeamcityOutput(): void
self::assertNotFalse($format);

$output = $result->output;
$output = preg_replace("/^Processes: \\d+\nRuntime: PHP \\d+.\\d+.\\d+(-\w+)?\n\n/", '', $output, 1, $count);
$output = preg_replace("/^Processes: \\d+\nRuntime: PHP \\d+\\.\\d+\\.\\w+(-\w+)?\n\n/", '', $output, 1, $count);
self::assertSame(1, $count);
self::assertNotNull($output);

Expand All @@ -270,7 +270,7 @@ public function testTestdoxOutput(): void
self::assertNotFalse($format);

$output = $result->output;
$output = preg_replace("/^Processes: \\d+\nRuntime: PHP \\d+.\\d+.\\d+(-.+)?\n\n/", '', $output, 1, $count);
$output = preg_replace("/^Processes: \\d+\nRuntime: PHP \\d+\\.\\d+\\.\\w+(-.+)?\n\n/", '', $output, 1, $count);
self::assertSame(1, $count);
self::assertNotNull($output);

Expand Down

0 comments on commit cf16fcb

Please sign in to comment.