Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporter: Upload symbols only if in given allowlist #3035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reporter: Upload symbols only if in given allowlist #3035

wants to merge 1 commit into from

Conversation

metalmatze
Copy link
Member

If an allowlist is given Parca Agent will only upload symbols for binaries matching the strings that are specific. The match happens with strings.Contains. So parca matches both parca and parca-agent.

@metalmatze
Copy link
Member Author

Relevant logs for this feature.

time="2025-02-27T12:12:13+01:00" level=info msg="using config file: config.yaml"
2025/02/27 12:12:13 INFO reporter found allowlist list="[parca ollama cuda torch]"
time="2025-02-27T12:12:14+01:00" level=info msg="executable found in allowlist, file: 'parca-agent' matches 'parca'"
time="2025-02-27T12:12:18+01:00" level=info msg="executable found in allowlist, file: 'libtorch_global_deps.so' matches 'torch'"
time="2025-02-27T12:12:18+01:00" level=info msg="executable found in allowlist, file: 'libcudart.so.12.8.57' matches 'cuda'"
time="2025-02-27T12:12:18+01:00" level=info msg="executable found in allowlist, file: 'libc10_cuda.so' matches 'cuda'"
time="2025-02-27T12:12:18+01:00" level=info msg="executable found in allowlist, file: 'libtorch.so' matches 'torch'"
time="2025-02-27T12:12:19+01:00" level=info msg="executable found in allowlist, file: 'libtorch_cpu.so' matches 'torch'"
time="2025-02-27T12:12:19+01:00" level=info msg="executable found in allowlist, file: 'libcuda.so.570.86.16' matches 'cuda'"
time="2025-02-27T12:12:20+01:00" level=info msg="executable found in allowlist, file: 'libtorch_python.so' matches 'torch'"
time="2025-02-27T12:12:20+01:00" level=info msg="executable found in allowlist, file: 'libtorch_cuda.so' matches 'cuda'"

umanwizard
umanwizard approved these changes Feb 27, 2025
View reviewed changes
config.yaml Outdated
Comment on lines 8 to 10
- source_labels: [__meta_cpuid]
target_label: cpuid
action: replace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's this being added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. That wasn't supposed to be in this PR. Thanks for noticing. 👍

@metalmatze metalmatze force-pushed the reporter-upload-allowlist branch from 2271455 to 1f66082 Compare February 27, 2025 18:47
@metalmatze
reporter: Upload symbols only if in given allowlist
193ad94 
If an allowlist is given Parca Agent will only upload symbols for binaries matching the strings that are specific. The match happens with `strings.Contains`. So `parca` matches both `parca` and `parca-agent`.
@metalmatze metalmatze force-pushed the reporter-upload-allowlist branch from 1f66082 to 193ad94 Compare February 27, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umanwizard umanwizard umanwizard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalmatze @umanwizard