MethodDelegate: allow for swapping value type with object, and allow ref for arg 0 on value type #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert pointless typo
|
That’s nice work! |
|
Maybe you can add some tests too? |
Eddio0141
force-pushed
the
master
branch
2 times, most recently
from
921e1e7
to
d6fb93f
Compare
repeat mutation to see effect fixed bind error restore missing test
|
Thanks! Also sorry for the messy commits, I've squashed them to two commits to try make it clean Also I just realised, this fix would only apply for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
AccessTools.MethodDelegateto let you useobjectwhere a value type existsAlso lets you use
reffor the first argument with value types, since currently you can't mutate structs from dynamic methods generated when open instance without boxing, so this lets you use delegates such asvoid MyFunc(ref UnityEngine.Resolution res);