Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert slim views to ERB #218

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Convert slim views to ERB #218

merged 2 commits into from
Apr 4, 2024

Conversation

adrienpoly
Copy link
Collaborator

The goal it to make the code base as inclusive as possible

Slim is great but :

  • it is not the Rails default
  • it is not as popular as ERB
  • Front end developers can understand ERB as it is close to HTML but are having hard time with slim

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 4, 2024
View reviewed changes
app/views/layouts/application.html.erb Dismissed Show dismissed Hide dismissed
app/views/layouts/application.html.erb Dismissed Show dismissed Hide dismissed
@adrienpoly adrienpoly merged commit fcdfa87 into master Apr 4, 2024
6 of 7 checks passed
@adrienpoly adrienpoly deleted the remove-slim branch April 4, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrienpoly