Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

add try-runtime-ci #81

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add try-runtime-ci #81

wants to merge 8 commits into from

Conversation

brunopgalvao
Copy link

@brunopgalvao brunopgalvao commented Sep 13, 2023

closes #76

This PR makes it so try-runtime will run when a migration label is added to a PR.

This is considered a template for a try-runtime CI pipeline. In order for this to be fully functional, an RPC node will need to be setup for the project with flags on it to enable large request/response size.

@brunopgalvao brunopgalvao self-assigned this Sep 13, 2023
@brunopgalvao
Copy link
Author

This test should fail as the the RPC node is not set up.

* feat: make default image work with stable Rust

* fix: label name
@brunopgalvao brunopgalvao marked this pull request as draft September 14, 2023 17:04
.github/workflows/try-runtime-mainnet.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime-devnet.yml Outdated Show resolved Hide resolved
@Moliholy
Copy link
Contributor

As a suggestion: I think rather than repeating the same setup in both environments it'd be worth to create a common setup like in trappist to reduce the size and improve readability. In any case this can definitely be a future improvement, so I leave it up to you.

@brunopgalvao
Copy link
Author

Took @Moliholy's suggestion and reduced code duplication by creating a custom Github Action action that can be used for both mainnet and devnet. Thanks to @stiiifff for the custom action idea.

Copy link
Contributor

@Moliholy Moliholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're now using the try-runtime standalone binary we should remove the TryRuntime command, as already done in Trappist. This PR seems like a good place to do so.

@weezy20
Copy link
Contributor

weezy20 commented Oct 4, 2023

[Suggestion] : Could this PR use an additional document inside docs/ describing the process for try-runtime briefly and setting up / using this github action (like setting up their RPC node) or the try-runtime-cli for downstream projects?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Try-runtime task
3 participants