Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at trying to upgrade this crate from using futures into async-await. The reason behind this change is to be able to convert substrate's consensus including finality-grandpa's
Environment
methods to async ones whereawait
can be used on calls to the keystore.The status of this PR is WIP. The following tests need to be fixed before this branch can be merged:
and
I am going to keep this draft PR around to be picked up later by someone knowledgable in finality-grandpa's logic to make the needed fixes and maybe get this PR to a mergable state.
Resolves #124