Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix hashbrown features under no-std #94

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Conversation

andresilva
Copy link
Contributor

The default set of features for hashbrown is: "ahash", "ahash-compile-time-rng", "inline-more".
Without "ahash" the HashMap API isn't implemented, so no-std build was broken by #90.

@andresilva
Copy link
Contributor Author

We should probably just replace these maps with BTrees, especially for no-std builds where we don't want to introduce a runtime DoS vector.

@rphmeier rphmeier merged commit 2cf3e45 into master Nov 21, 2019
@andresilva andresilva deleted the andre/fix-no-std branch June 13, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants