Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more comment #827

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Add more comment #827

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1d2270
Add more comment
rongyi Feb 5, 2024
54b001f
Apply suggestions from code review
ordian Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rlp/src/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ impl RlpStream {
_ => {
// payload is longer than 1 byte only for lists > 55 bytes
// by pushing always this 1 byte we may avoid unnecessary shift of data
// both cases will need at least 1 byte header, so here, we blindly push 1 byte
ordian marked this conversation as resolved.
Show resolved Hide resolved
// and then when we know the exactly size of data in we will update this value
// accordingly, the update detail can be found in insert_list_payload method
ordian marked this conversation as resolved.
Show resolved Hide resolved
self.buffer.put_u8(0);

let position = self.total_written();
Expand Down
Loading