Skip to content

Commit

Permalink
Indicate the hackish nature of the approach in the comment
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitry-markin committed Dec 27, 2024
1 parent 8696173 commit 156ec52
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions substrate/client/service/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,10 @@ where
// sync protocol is initiated fast enough
// (see https://github.com/paritytech/polkadot-sdk/issues/6573#issuecomment-2563091343).
//
// The solution is far from ideal, because in the client code the nework starter is
// activated once all the tasks are spawned, not once they finished the initialization,
// so the race can still happen.
//
// This hack is needed at least until protocol peer sets are made independed.
// See the discussion in https://github.com/paritytech/polkadot-sdk/issues/7006.
let (network_start_tx, network_start_rx) = oneshot::channel();
Expand Down

0 comments on commit 156ec52

Please sign in to comment.