fix: ensure_account_can_die should happen before mutating dest on…

… `transfer_and_die`.

substrate/frame/assets/src/functions.rs

@@ -688,6 +688,15 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 			debug_assert!(source_account.balance >= debit, "checked in prep; qed");
 			source_account.balance = source_account.balance.saturating_sub(debit);
 
+			// Pre-check that an account can die if is below min balance
+			if source_account.balance < details.min_balance {
+				source_died =
+					Some(Self::dead_account(source, details, &source_account.reason, false));
+				if let Some(Remove) = source_died {
+					Self::ensure_account_can_die(id.clone(), source)?;
+				}
+			}
+
 			Account::<T, I>::try_mutate(&id, &dest, |maybe_account| -> DispatchResult {
 				match maybe_account {
 					Some(ref mut account) => {
@@ -714,10 +723,7 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 			// Remove source account if it's now dead.
 			if source_account.balance < details.min_balance {
 				debug_assert!(source_account.balance.is_zero(), "checked in prep; qed");
-				source_died =
-					Some(Self::dead_account(source, details, &source_account.reason, false));
 				if let Some(Remove) = source_died {
-					Self::ensure_account_can_die(id.clone(), source)?;
 					Account::<T, I>::remove(&id, &source);
 					return Ok(())
 				}