Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zombienet tests for malicious collators #4526

Open
alindima opened this issue May 20, 2024 · 3 comments
Open

Add zombienet tests for malicious collators #4526

alindima opened this issue May 20, 2024 · 3 comments
Assignees
@sw10pa
Labels
T10-tests This PR/Issue is related to tests.

Comments

@alindima
Copy link
Contributor

AFAICT we don't have zombienet tests for malicious collators and checking their potential impact on the network.

Some scenarios off the top of my head:

  • collators trying to DOS backers by overloading them with advertisements/collations (check that the reputation changes provide a reasonable mitigation)
  • collators providing invalid collations. the other honest collators should still be able to get blocks in.
  • collators deliberately creating parachain forks. throughput should decrease but the parachain should not stall.
@alindima alindima added the T10-tests This PR/Issue is related to tests. label May 20, 2024
@sandreim
Copy link
Contributor

This is more than just tests, we need a malus-test-collator.

@bkchr
Copy link
Member

bkchr commented May 23, 2024

This is more than just tests, we need a malus-test-collator.

For nothing of what is said above, you need a "malus collator". You basically just need to send junk.

@alindima
Copy link
Contributor Author

alindima commented Jun 3, 2024

another test scenario: collator spamming validators with chunk requests for pov recovery

@alindima alindima mentioned this issue Nov 13, 2024
Closed
4 tasks
@sw10pa sw10pa self-assigned this Nov 19, 2024
@sw10pa sw10pa mentioned this issue Dec 17, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 30, 2025
@sw10pa
malus-collator: implement malicious collator submitting same collatio…
48f69cc 
…n to all backing groups (#6924)

## Issues
- [[#5049] Elastic scaling: zombienet
tests](#5049)
- [[#4526] Add zombienet tests for malicious
collators](#4526)

## Description
Modified the undying collator to include a malus mode, in which it
submits the same collation to all assigned backing groups.

## TODO
* [X] Implement malicious collator that submits the same collation to
all backing groups;
* [X] Avoid the core index check in the collation generation subsystem:
https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/node/collation-generation/src/lib.rs#L552-L553;
* [X] Resolve the mismatch between the descriptor and the commitments
core index: #7104
* [X] Implement `duplicate_collations` test with zombienet-sdk;
* [X] Add PRdoc.
Ank4n pushed a commit that referenced this issue Feb 6, 2025
@sw10pa @Ank4n
malus-collator: implement malicious collator submitting same collatio…
1f7c73b 
…n to all backing groups (#6924)

## Issues
- [[#5049] Elastic scaling: zombienet
tests](#5049)
- [[#4526] Add zombienet tests for malicious
collators](#4526)

## Description
Modified the undying collator to include a malus mode, in which it
submits the same collation to all assigned backing groups.

## TODO
* [X] Implement malicious collator that submits the same collation to
all backing groups;
* [X] Avoid the core index check in the collation generation subsystem:
https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/node/collation-generation/src/lib.rs#L552-L553;
* [X] Resolve the mismatch between the descriptor and the commitments
core index: #7104
* [X] Implement `duplicate_collations` test with zombienet-sdk;
* [X] Add PRdoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sw10pa sw10pa

Labels
T10-tests This PR/Issue is related to tests.
Projects
parachains team board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bkchr @alindima @sandreim @sw10pa