malus-collator: implement malicious collator submitting same collation to all backing groups #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or submitting same collation to all backing groups
…o Collator implementation
…extend test scenario
alindima
reviewed
Jan 13, 2025
polkadot/parachain/test-parachains/undying/collator/src/main.rs
Outdated
Show resolved
Hide resolved
alindima
reviewed
Jan 13, 2025
polkadot/zombienet_tests/functional/0020-same-collation-to-all-assigned-cores.zndsl
Outdated
Show resolved
Hide resolved
alindima
reviewed
Jan 13, 2025
polkadot/zombienet_tests/functional/0020-same-collation-to-all-assigned-cores.zndsl
Outdated
Show resolved
Hide resolved
sandreim
reviewed
Jan 13, 2025
polkadot/zombienet_tests/functional/0020-same-collation-to-all-assigned-cores.toml
Outdated
Show resolved
Hide resolved
alindima
reviewed
Jan 13, 2025
alindima
reviewed
Jan 24, 2025
sw10pa
changed the title
sw10pa
changed the title
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
alindima
approved these changes
Jan 29, 2025
polkadot/parachain/test-parachains/undying/collator/tests/integration.rs
Show resolved
Hide resolved
ordian
approved these changes
Jan 30, 2025
…polkadot from prdoc bumps
AndWeHaveAPlan
approved these changes
Jan 30, 2025
alvicsam
approved these changes
Jan 30, 2025
pepoviola
reviewed
Jan 30, 2025
pepoviola
approved these changes
Jan 30, 2025
ordian
added a commit
that referenced
this pull request
Feb 3, 2025
* master: Remove warnings by cleaning up the `Cargo.toml` (#7416) [Backport] Version bumps from stable2412-1 + prdocs reorg (#7401) fix pre-dispatch PoV underweight for ParasInherent (#7378) malus-collator: implement malicious collator submitting same collation to all backing groups (#6924) `fatxpool`: use tracing for logging (#6897) Improvements for Weekly bench (#7390) Replace derivative dependency with derive-where (#7324) Add support for feature `pallet_balances/insecure_zero_ed` in benchmarks and testing (#7379) Fix Snowbridge benchmark tests (#7296) Bridges small nits/improvements (#7383) Migrating cumulus-pallet-session-benchmarking to Benchmarking V2 (#6564) [pallet-revive] implement the block author API (#7198) Use checked math in frame-balances named_reserve (#7365) move installation of frame-omni-bencher into a cmd.py itself (#7372) remove old bench & revert the frame-weight-template (#7362) ci: fix workflow permissions (#7366) [net/libp2p] Use raw `Identify` observed addresses to discover external addresses (#7338) Improve `set_validation_data` error message. (#7359) Implement pallet view function queries (#4722)
Ank4n
pushed a commit
that referenced
this pull request
Feb 6, 2025
…n to all backing groups (#6924) ## Issues - [[#5049] Elastic scaling: zombienet tests](#5049) - [[#4526] Add zombienet tests for malicious collators](#4526) ## Description Modified the undying collator to include a malus mode, in which it submits the same collation to all assigned backing groups. ## TODO * [X] Implement malicious collator that submits the same collation to all backing groups; * [X] Avoid the core index check in the collation generation subsystem: https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/node/collation-generation/src/lib.rs#L552-L553; * [X] Resolve the mismatch between the descriptor and the commitments core index: #7104 * [X] Implement `duplicate_collations` test with zombienet-sdk; * [X] Add PRdoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
Modified the undying collator to include a malus mode, in which it submits the same collation to all assigned backing groups.
TODO
duplicate_collationstest with zombienet-sdk;