Fix delivery fees issue #3085
Merged
Fix delivery fees issue #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
approved these changes
Jan 26, 2024
franciscoaguirre
added
the
R0-silent
Signed-off-by: Adrian Catangiu <[email protected]>
Signed-off-by: Adrian Catangiu <[email protected]>
acatangiu
approved these changes
Jan 26, 2024
xlc
reviewed
Jan 27, 2024
| vec![ReserveAssetDeposited(to_weigh.into()), ClearOrigin]; | ||
| message_to_weigh.extend(xcm.0.clone().into_iter()); | ||
| let (_, fee) = | ||
| validate_send::<Config::XcmSender>(dest.clone(), Xcm(message_to_weigh))?; |
There was a problem hiding this comment.
should we just modify send to not charge fee and have another method that charges send fee and call it here? so that we don't need to calculate the send fee multiple times
1 task
|
@franciscoaguirre what are we waiting for? |
On it |
|
Hello dears , I need your help for back my tokens ,it stucks and here's the extrinsic hash |
Closed
franciscoaguirre
added a commit
that referenced
this pull request
Feb 5, 2024
This fix aims to solve an issue in Kusama that resulted in failed reserve asset transfers. It will be ported later to master as well. The issue is that during multi-hop XCMs, like reserve asset transfers where the reserve is not the sender nor the destination, there are no assets available to pay for delivery fees. This fix makes sure to deduct delivery fees from the assets being transferred. - [x] code changes required for fix now complete - [x] local testing done shows issue as fixed - [x] regression test added - [x] PR reviewed - [x] CI passing - currently issue with CI not running on non-master PR - [ ] xcm-executor patch version 4.0.1 released - [ ] xcm-executor patch version 4.0.1 included in https://github.com/polkadot-fellows/runtimes/ - [ ] Kusama and Polkadot runtimes patch released --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Keith Yeung <[email protected]>
girazoki
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Mar 19, 2024
This fix aims to solve an issue in Kusama that resulted in failed reserve asset transfers. It will be ported later to master as well. The issue is that during multi-hop XCMs, like reserve asset transfers where the reserve is not the sender nor the destination, there are no assets available to pay for delivery fees. This fix makes sure to deduct delivery fees from the assets being transferred. - [x] code changes required for fix now complete - [x] local testing done shows issue as fixed - [x] regression test added - [x] PR reviewed - [x] CI passing - currently issue with CI not running on non-master PR - [ ] xcm-executor patch version 4.0.1 released - [ ] xcm-executor patch version 4.0.1 included in https://github.com/polkadot-fellows/runtimes/ - [ ] Kusama and Polkadot runtimes patch released --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Keith Yeung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aims to solve an issue in Kusama that resulted in failed reserve asset transfers.
It will be ported later to master as well.
The issue is that during multi-hop XCMs, like reserve asset transfers where the reserve is not the sender nor the destination, there are no assets available to pay for delivery fees.
This fix makes sure to deduct delivery fees from the assets being transferred.