Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pallet-asset-rewards #3926

Merged
merged 200 commits into from
Jan 16, 2025
Merged

Implement pallet-asset-rewards #3926

merged 200 commits into from
Jan 16, 2025

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Apr 1, 2024 •
edited
Loading

Closes #3149

Description

This PR introduces pallet-asset-rewards, which allows accounts to be rewarded for freezing fungible tokens. The motivation for creating this pallet is to allow incentivising LPs.

See the pallet docs for more info about the pallet.

Runtime changes

The pallet has been added to

  • asset-hub-rococo
  • asset-hub-westend

The NativeAndAssets fungibles Union did not contain PoolAssets, so it has been renamed NativeAndNonPoolAssets

A new fungibles Union NativeAndAllAssets was created to encompass all assets and the native token.

TODO

@liamaharon liamaharon added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Apr 1, 2024
@liamaharon liamaharon changed the title Implement pallet-staking-rewards Implement pallet-asset-rewards Apr 1, 2024
@muharem
Copy link
Contributor

muharem commented Jan 14, 2025

bot bench-all pallet --pallet=pallet_asset_rewards
bot bench cumulus-assets --pallet=pallet_asset_rewards --runtime asset-hub-westend
bot bench cumulus-assets --pallet=pallet_asset_rewards --runtime asset-hub-rococo

@command-bot
Copy link

command-bot bot commented Jan 14, 2025 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010046 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=pallet_asset_rewards. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-1cff81f4-79bf-44a4-b2b6-a4ac7a20cfe5 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 14, 2025 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010047 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-b1f23a62-8771-4f6b-a51e-4a812661a92d to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 14, 2025 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010048 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-fc54f295-0955-4bc0-ab17-fb8009906aac to cancel this command or bot cancel to cancel all commands in this pull request.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
c9eb609 
…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards
@command-bot
Copy link

command-bot bot commented Jan 14, 2025

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010047 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010047/artifacts/download.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
7a1e113 
…=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards
@command-bot
Copy link

command-bot bot commented Jan 14, 2025

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010048 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010048/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jan 14, 2025

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=pallet_asset_rewards has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010046 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8010046/artifacts/download.

@muharem
Copy link
Contributor

muharem commented Jan 14, 2025

bot help

@command-bot
Copy link

command-bot bot commented Jan 14, 2025

Here's a link to docs

@muharem
Copy link
Contributor

muharem commented Jan 14, 2025

bot bench substrate-pallet --pallet=pallet_asset_rewards

@command-bot
Copy link

command-bot bot commented Jan 14, 2025 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8011480 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_asset_rewards. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-29cad09f-694a-4309-9ad0-3fed1664623f to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 14, 2025

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_asset_rewards has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8011480 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8011480/artifacts/download.

@muharem
Copy link
Contributor

muharem commented Jan 14, 2025

bot bench substrate-pallet --pallet=pallet_asset_rewards --features

@command-bot
Copy link

command-bot bot commented Jan 14, 2025

@muharem option '--features ' argument missing

@muharem
Copy link
Contributor

muharem commented Jan 14, 2025

bot bench substrate-pallet --pallet=pallet_asset_rewards --features=runtime-benchmarks

@command-bot
Copy link

command-bot bot commented Jan 14, 2025 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8013095 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_asset_rewards. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-eaad2048-3292-4e2c-9902-31fae79027ed to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot added 2 commits January 14, 2025 14:14
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
8bd72af 
…nto HEAD
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
7e9cb27 
…=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_asset_rewards
@command-bot
Copy link

command-bot bot commented Jan 14, 2025

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_asset_rewards has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8013095 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8013095/artifacts/download.

@muharem muharem added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@muharem muharem added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit be2404c Jan 16, 2025
194 of 204 checks passed
@muharem muharem deleted the liam-staking-rewards-pallet branch January 16, 2025 07:01
ordian added a commit that referenced this pull request Jan 16, 2025
@ordian
Merge branch 'master' into ao-migrate-zombie-past-slashing-test
75fe402 
* master: (33 commits)
  Implement `pallet-asset-rewards` (#3926)
  [pallet-revive] Add host function `to_account_id` (#7091)
  [pallet-revive] Remove revive events (#7164)
  [pallet-revive] Remove debug buffer (#7163)
  litep2p: Provide partial results to speedup GetRecord queries (#7099)
  [pallet-revive] Bump asset-hub westend spec version (#7176)
  Remove 0 as a special case in gas/storage meters (#6890)
  [pallet-revive] Fix `caller_is_root` return value (#7086)
  req-resp/litep2p: Reject inbound requests from banned peers (#7158)
  Add "run to block" tools (#7109)
  Fix reversed error message in DispatchInfo (#7170)
  approval-voting: Make importing of duplicate assignment idempotent (#6971)
  Parachains: Use relay chain slot for velocity measurement (#6825)
  PRDOC: Document `validate: false` (#7117)
  xcm: convert properly assets in xcmpayment apis (#7134)
  CI: Only format umbrella crate during umbrella check (#7139)
  approval-voting: Fix sending of assignments after restart (#6973)
  Retry approval on availability failure if the check is still needed (#6807)
  [pallet-revive-eth-rpc] persist eth transaction hash (#6836)
  litep2p: Sufix litep2p to the identify agent version for visibility (#7133)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkontur bkontur bkontur left review comments

@muharem muharem muharem left review comments

@gui1117 gui1117 gui1117 approved these changes

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Asset Conversion] Incentives Extension
9 participants
@liamaharon @drewstone @Polkadot-Forum @muharem @paritytech-cicd-pr @gui1117 @kianenigma @bkontur @ggwpez