Change sorted list types and simplify type conversions in stake-tracker #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI pipeline was cancelled due to failure one of the required jobs. |
gpestana
added a commit
that referenced
this pull request
May 10, 2024
- Changes the target list score type from balance to `u128` (`ExtendedBalance`) - simplifies `balance/ vote_weight/ extended_balance` conversions - relies less on the currency total issuance call - ensures approval stake calculations/storage is safe - Simplifies stake tracker logic - removes a few redundant checks - split `on_stake_update` code - Ensures `VoterUpdateMode` is taken into consideration in try-state checks - use voter mode lazy in benchmarks - update weights + check the diff with voter lazy - Docs improvements - All tests passing after merging validator disabling and virtual stakers **new** - ensures duplicate nominations are dedup before calculating the approvals stake - chills nominator after total slash to ensure the target can be reaped/kill without leaving nominations behind. - ensures that switching from validator to nominator and back is correct - a nominator may have an entry in the targetlist (if it was a validator + has nominations) - ensure target node is removed if balance is 0 and it is a nominator. - addresses paritytech-secops/srlabs_findings#383 --- **Other experiments:** (not included) - #4402 (passing the status of the staker with who in the OnStakingUpdate interface is less clean, it turns out) - #4361 --------- Co-authored-by: command-bot <>
|
closing as this change will not be introduced in stake tracker. Opened a tracking issue to tackle this refactor later on #4725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the voter and sorted lists score types.
BalancetoExtendedBalance: for safety.VoteWeighttoBalance: to avoid conversions to vote weight. (can we do this though? what if the vote weight is > u64)This way, the conversion to
VoteWeight(which requires the a call toT::Currency::total_issuance) is reduced to a minimum and never required at the stake-tracker level. The target list score isExtendedBalancefor safety, as the approvals stakes with unbounded nominations may overflow u64.Note that the end of the day, the voter and target lists are used to keep stakers sorted by stake/approval stakes.
Converting the voter score from
VoteWeighttoBalancerequires a migration since vote_weight(account) != active_stake(account)`