Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Create release draft workflow + templates for the free notes and docker images sections in the notes #4371

Merged

Conversation

EgorPopelyaev
Copy link
Contributor

This PR has the following changes:

  • New templates for the free notes and docker images sections in the release notes. There is going to be a section for the manual additions to the release notes + a section with the links to the docker images for polkadot and polkadot-parachain binaries at the end of the release draft.
  • Fix for matrix section in the Create release draft flow (adds the release environment variable)
  • Reduction of the message which is posted to the announcement chats, as the current one with the full release notes text is too big.

@EgorPopelyaev EgorPopelyaev added R0-silent Changes should not be mentioned in any release notes I5-enhancement An additional feature request. labels May 3, 2024
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners May 3, 2024 14:33
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 6, 2024 09:05
@EgorPopelyaev EgorPopelyaev requested a review from a team May 6, 2024 12:15
@EgorPopelyaev EgorPopelyaev enabled auto-merge May 6, 2024 12:17
You may also pull it with:

```
docker pull parity/polkadot:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the hash could be in here to ensure that they pull the released version.

@@ -48,5 +48,3 @@ jobs:
Release version: [${{github.event.release.tag_name}}](${{github.event.release.html_url}})

-----

${{github.event.release.body}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is a link to the full notes instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is a link to the full notes instead?

Yep, otherwise it might fail like after the last release, because the message was too large for the Element

@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue May 6, 2024
Merged via the queue into paritytech:master with commit e434176 May 6, 2024
159 of 161 checks passed
@EgorPopelyaev EgorPopelyaev deleted the ep-fix-publish-draft-flow branch May 6, 2024 15:02
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…and docker images sections in the notes (paritytech#4371)

This PR has the following changes:

- New templates for the free notes and docker images sections in the
release notes. There is going to be a section for the manual additions
to the release notes + a section with the links to the docker images for
`polkadot` and `polkadot-parachain` binaries at the end of the release
draft.
- Fix for matrix section in the Create release draft flow (adds the
release environment variable)
- Reduction of the message which is posted to the announcement chats, as
the current one with the full release notes text is too big.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…and docker images sections in the notes (paritytech#4371)

This PR has the following changes:

- New templates for the free notes and docker images sections in the
release notes. There is going to be a section for the manual additions
to the release notes + a section with the links to the docker images for
`polkadot` and `polkadot-parachain` binaries at the end of the release
draft.
- Fix for matrix section in the Create release draft flow (adds the
release environment variable)
- Reduction of the message which is posted to the announcement chats, as
the current one with the full release notes text is too big.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants