[DNM] gha tests

.forklift/config.toml

@@ -7,7 +7,7 @@ compressionLevel = 3
 [general]
 jobNameVariable = "CI_JOB_NAME"
 jobsBlackList = []
-logLevel = "warn"
+logLevel = "trace"
 threadsCount = 6
 
 [cache]

.github/codecov.yml

@@ -6,4 +6,7 @@ coverage:
     project:
       default:
         target: 1.0
-        threshold: 2.0
+        threshold: 2.0
+
+fixes:
+  - "/__w/polkadot-sdk/polkadot-sdk/::"

.github/env

@@ -1 +1 @@
-IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507"
+IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507"

.github/scripts/group-crates.py

@@ -0,0 +1,48 @@
+import subprocess, sys
+
+# Get all crates
+output = subprocess.check_output(["cargo", "tree", "--locked", "--workspace", "--depth", "0", "--prefix", "none", "--features", "try-runtime,ci-only-tests,experimental,riscv"])
+
+# Convert the output into a proper list
+crates = []
+for line in output.splitlines():
+	if line != b"":
+		line = line.decode('utf8').split(" ")
+		crate_name = line[0]
+		# The crate path is always the last element in the line.
+		crate_path = line[len(line) - 1].replace("(", "").replace(")", "")
+		crates.append(crate_name)
+
+# Make the list unique and sorted
+crates = list(set(crates))
+crates.sort()
+
+#print(f'total crates: {len(crates)}')
+
+#
+current_group = int(sys.argv[1]) - 1
+total_groups = int(sys.argv[2])
+
+cratesPerGroup = len(crates) // total_groups
+
+if current_group >= total_groups:
+	print("`current group` is greater than `total groups`")
+	sys.exit(1)
+
+#print(f'group {current_group+1}/{total_groups}, {cratesPerGroup} crates per group')
+
+#
+start = cratesPerGroup * current_group
+end = cratesPerGroup * (current_group + 1)
+
+if current_group + 1 == total_groups:
+	end = len(crates)
+
+#
+part = crates[start : end]
+
+result = 'package('+part[0]+')'
+for pkg in part[1:]:
+    result += ' + package('+pkg+')'
+
+print(result)

.github/workflows/tests-linux-stable.yml

@@ -71,3 +71,92 @@ jobs:
         uses: actions/checkout@v4
       - name: script
         run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet
+
+  #
+  test-linux-stable:
+    needs: [set-image, changes]
+    runs-on: arc-runners-polkadot-sdk-beefy
+    timeout-minutes: 120
+    container:
+      image: ${{ needs.set-image.outputs.IMAGE }}
+    env:
+      RUST_TOOLCHAIN: stable
+      # Enable debug assertions since we are running optimized builds for testing
+      # but still want to have debug assertions.
+      RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings -Cinstrument-coverage"
+      #LLVM_PROFILE_FILE: "target/coverage/cargo-test-${{ matrix.ci_node_index }}-%p-%m.profraw"
+      LLVM_PROFILE_FILE: "/__w/polkadot-sdk/polkadot-sdk/target/coverage/cargo-test-${{ matrix.ci_node_index }}-%p-%m.profraw"
+    strategy: 
+      fail-fast: false     
+      matrix:
+        ci_node_total: [5]
+        ci_node_index: [1, 2, 3, 4, 5]      
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: update forklift
+        run: /builds/download-forklift.sh -v master -p ./forklift/
+      - run: forklift version
+
+      - run: rustup component add llvm-tools-preview
+      - run: cargo install cargo-llvm-cov
+
+      - run: mkdir -p target/coverage/result
+      - name: script
+        run: >
+          time forklift cargo llvm-cov nextest
+          --no-report --release
+          --workspace
+          --locked --no-fail-fast
+          --features try-runtime,ci-only-tests,experimental,riscv
+          --filter-expr "
+          !test(/.*benchmark.*/)
+          - test(/recovers_from_only_chunks_if_pov_large::case_1/)
+          - test(/participation_requests_reprioritized_for_newly_included/)
+          - test(/availability_is_recovered_from_chunks_if_no_group_provided::case_1/)
+          - test(/rejects_missing_inherent_digest/)
+          - test(/availability_is_recovered_from_chunks_even_if_backing_group_supplied_if_chunks_only::case_1/)
+          - test(/availability_is_recovered_from_chunks_if_no_group_provided::case_2/)
+          - test(/all_security_features_work/)
+          - test(/nonexistent_cache_dir/)
+          - test(/recovers_from_only_chunks_if_pov_large::case_3/)
+          - test(/recovers_from_only_chunks_if_pov_large::case_2/)
+          - test(/authoring_blocks/)
+          - test(/rejects_missing_seals/)       
+          - test(/generate_chain_spec/) 
+          - test(/get_preset/)
+          - test(/list_presets/)  
+          - test(/tests::receive_rate_limit_is_enforced/)
+          - test(/polkadot-availability-recovery/)
+          "          
+          --partition count:${{ matrix.ci_node_index }}/${{ matrix.ci_node_total }}
+      - run: ls -al target/coverage
+      - run: ls -al /__w/polkadot-sdk/polkadot-sdk/target
+      - run: ls -al /__w/polkadot-sdk/polkadot-sdk/target/llvm-cov-target
+      - name: generate report
+        run: cargo llvm-cov report --release --codecov --output-path coverage-${{ matrix.ci_node_index }}.lcov
+      - run: ls -al
+      - name: upload report
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report-${{ matrix.ci_node_index }}.lcov
+          path: coverage-${{ matrix.ci_node_index }}.lcov
+#
+  upload-reports:
+    needs: [test-linux-stable]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: reports
+          pattern: coverage-report-*
+          merge-multiple: true    
+      - run: ls -al reports/      
+      - name: Upload to Codecov
+        uses: codecov/codecov-action@v4 
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true 
+          directory: reports
+          root_dir: /__w/polkadot-sdk/polkadot-sdk/

.gitlab/pipeline/test.yml

@@ -154,6 +154,7 @@ test-linux-stable:
     reports:
       junit: target/nextest/default/junit.xml
   timeout: 90m
+  when: manual
 
 test-linux-oldkernel-stable:
   extends: test-linux-stable

substrate/bin/node/runtime/src/lib.rs

@@ -506,8 +506,7 @@ impl pallet_babe::Config for Runtime {
 	type WeightInfo = ();
 	type MaxAuthorities = MaxAuthorities;
 	type MaxNominators = MaxNominators;
-	type KeyOwnerProof =
-		<Historical as KeyOwnerProofSystem<(KeyTypeId, pallet_babe::AuthorityId)>>::Proof;
+	type KeyOwnerProof = sp_session::MembershipProof;
 	type EquivocationReportSystem =
 		pallet_babe::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
 }
@@ -1487,7 +1486,7 @@ impl pallet_grandpa::Config for Runtime {
 	type MaxAuthorities = MaxAuthorities;
 	type MaxNominators = MaxNominators;
 	type MaxSetIdSessionEntries = MaxSetIdSessionEntries;
-	type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, GrandpaId)>>::Proof;
+	type KeyOwnerProof = sp_session::MembershipProof;
 	type EquivocationReportSystem =
 		pallet_grandpa::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
 }
@@ -2548,7 +2547,7 @@ impl pallet_beefy::Config for Runtime {
 	type OnNewValidatorSet = MmrLeaf;
 	type AncestryHelper = MmrLeaf;
 	type WeightInfo = ();
-	type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, BeefyId)>>::Proof;
+	type KeyOwnerProof = sp_session::MembershipProof;
 	type EquivocationReportSystem =
 		pallet_beefy::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
 }

substrate/frame/babe/src/mock.rs

@@ -25,12 +25,12 @@ use frame_election_provider_support::{
 };
 use frame_support::{
 	derive_impl, parameter_types,
-	traits::{ConstU128, ConstU32, ConstU64, KeyOwnerProofSystem, OnInitialize},
+	traits::{ConstU128, ConstU32, ConstU64, OnInitialize},
 };
 use pallet_session::historical as pallet_session_historical;
 use sp_consensus_babe::{AuthorityId, AuthorityPair, Randomness, Slot, VrfSignature};
 use sp_core::{
-	crypto::{KeyTypeId, Pair, VrfSecret},
+	crypto::{Pair, VrfSecret},
 	U256,
 };
 use sp_io;
@@ -182,7 +182,7 @@ impl Config for Test {
 	type WeightInfo = ();
 	type MaxAuthorities = ConstU32<10>;
 	type MaxNominators = ConstU32<100>;
-	type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, AuthorityId)>>::Proof;
+	type KeyOwnerProof = sp_session::MembershipProof;
 	type EquivocationReportSystem =
 		super::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
 }

substrate/frame/grandpa/src/mock.rs

@@ -28,11 +28,11 @@ use frame_election_provider_support::{
 };
 use frame_support::{
 	derive_impl, parameter_types,
-	traits::{ConstU128, ConstU32, ConstU64, KeyOwnerProofSystem, OnFinalize, OnInitialize},
+	traits::{ConstU128, ConstU32, ConstU64, OnFinalize, OnInitialize},
 };
 use pallet_session::historical as pallet_session_historical;
 use sp_consensus_grandpa::{RoundNumber, SetId, GRANDPA_ENGINE_ID};
-use sp_core::{crypto::KeyTypeId, H256};
+use sp_core::{H256};
 use sp_keyring::Ed25519Keyring;
 use sp_runtime::{
 	curve::PiecewiseLinear,
@@ -186,7 +186,7 @@ impl Config for Test {
 	type MaxAuthorities = ConstU32<100>;
 	type MaxNominators = ConstU32<1000>;
 	type MaxSetIdSessionEntries = MaxSetIdSessionEntries;
-	type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, AuthorityId)>>::Proof;
+	type KeyOwnerProof = sp_session::MembershipProof;
 	type EquivocationReportSystem =
 		super::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
 }