feat: reduce coupling between salary and core-fellowship pallet #5159
+42
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3617
Description
Introduce a new parameter to define the salary of rank for a specific duration (currently in number of blocks), in the
core-fellowshippallet. This enables other pallets using this salary information to derive the actual "salary" to give after a certain amount of blocks have passed.Specifically, for the
salarypallet, we can now independently calculate the salary to distribute based on the difference in cycles, without having to know what "duration" means incore-fellowshipPerhaps it might be useful to define an auxiliary type to facilitate conversion between "duration" and "cycles"