-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Add offchain executor params #5278
base: master
Are you sure you want to change the base?
Conversation
The CI pipeline was cancelled due to failure one of the required jobs. |
related: #5419 |
Generally I don't see any reason to keep this pr. Will not be merged in this form. |
@bkchr, please do not delete the branch at least. Several developers use it for state-size experiments. |
@s0me0ne-unkn0wn as you see I did not delete the branch. Even if I would do it, the pr would still be here. |
@bkchr a couple of questions:
|
None of the changes in the pr are required, if we would concentrate our work on moving the collator into the runtime. Apparently the contracts team wants to do the same and there are also more and more issues around the allocator. So, I hope that there is enough traction that finally someone does it. Also the changes should not be that complicated, just takes time for someone to do it. |
But even with the allocator moved to the runtime, we'll still have offchain execution, like when building chainspec, etc. My intent here is to be able to parameterize such executions as well as we're currently able to parameterize onchain execution with executor params. Setting the allocation limit is not the only use case possible. |
When we have an in-runtime allocator, we will not have a per allocation limit anymore. We will only have an total allocation limit, which is already configurable for offchain and onchain. |
All GitHub workflows were cancelled due to failure one of the required jobs. |
Do not merge. Not in this form definitely.
TODO: make allocator distinguish between onchain and offchain mode and have different single allocation limits depending on mode