Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small nits for XCMv5 #6383

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Small nits for XCMv5 #6383

merged 7 commits into from
Nov 6, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Nov 6, 2024 •
edited
Loading

Small nits for XCMv5 found during review:

  • MaxDispatchErrorLen cleanup
  • Use xcm::latest instead of xcm::v5
  • Use the same SendXcm import for coretime migration

@bkontur bkontur added the R0-silent Changes should not be mentioned in any release notes label Nov 6, 2024
@bkontur bkontur requested a review from a team as a code owner November 6, 2024 09:28
@bkontur bkontur mentioned this pull request Nov 6, 2024
Merged
10 tasks
@bkontur
Copy link
Contributor Author

bkontur commented Nov 6, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 6, 2024 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7707640 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 42-383739af-2b72-4283-bf3c-ef9980850da2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 6, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7707640 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7707640/artifacts/download.

acatangiu
acatangiu approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why there are so many formatting changes, but functionally everything looks good!

@acatangiu acatangiu merged commit c2706e6 into xcm-v5 Nov 6, 2024
113 of 140 checks passed
@acatangiu acatangiu deleted the xcm-v5-nits branch November 6, 2024 11:28
@bkontur
Copy link
Contributor Author

bkontur commented Nov 6, 2024

I'm not sure why there are so many formatting changes, but functionally everything looks good!

hmm, I am not sure also, I just used bot fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkontur @acatangiu