Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic scaling RFC 103 end-to-end test #6452

Merged
merged 32 commits into from
Dec 18, 2024
Merged

Conversation

alindima
Copy link
Contributor

@alindima alindima commented Nov 12, 2024

Adds a new zombienet-sdk test which verifies that elastic scaling works correctly both with the MVP and the new RFC 103 implementation which sends the core selector as a UMP signal.

Also enables the V2 receipts node feature for testnet genesis config.

Part of #5049

@alindima alindima added R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network. T10-tests This PR/Issue is related to tests. labels Nov 12, 2024
@alindima alindima requested a review from a team as a code owner November 12, 2024 12:00
@alindima alindima requested a review from sandreim November 12, 2024 12:11
@alindima alindima changed the title elastic scaling RFC 103 end-to-end test elastic scaling RFC 103 end-to-end tests Dec 2, 2024
@alindima alindima added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@alindima alindima enabled auto-merge December 4, 2024 09:57
@alindima alindima added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@sandreim sandreim mentioned this pull request Dec 9, 2024
10 tasks
@alindima alindima enabled auto-merge December 10, 2024 08:17
@alindima alindima disabled auto-merge December 10, 2024 11:26
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12297500276
Failed job name: test-doc

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12297500276
Failed job name: build-rustdoc

@alindima alindima changed the title elastic scaling RFC 103 end-to-end tests elastic scaling RFC 103 end-to-end test Dec 17, 2024
@alindima alindima added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit f24007e Dec 18, 2024
200 of 201 checks passed
@alindima alindima deleted the alindima/rfc-103-test branch December 18, 2024 08:33
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
Adds a new zombienet-sdk test which verifies that elastic scaling works
correctly both with the MVP and the new RFC 103 implementation which
sends the core selector as a UMP signal.

Also enables the V2 receipts node feature for testnet genesis config.

Part of paritytech#5049

---------

Co-authored-by: Javier Viola <[email protected]>
Co-authored-by: Javier Viola <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
Fix this zombienet test

It was failing because in
#6452 I enabled the v2
receipts for testnet genesis,
so the collators started sending v2 receipts with zeroed collator
signatures to old validators that were still checking those signatures
(which lead to disputes, since new validators considered the candidates
valid).

The fix is to also use an old image for collators, so that we don't
create v2 receipts.

We cannot remove this test yet because collators also perform chunk
recovery, so until all collators are upgraded, we need to maintain this
compatibility with the old protocol version (which is also why
systematic recovery was not yet enabled)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network. T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants