revive: Bump connect timeout to fix flaky tests #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Nov 20, 2024
ordian
reviewed
Nov 20, 2024
pgherveou
approved these changes
Nov 21, 2024
| @@ -32,9 +32,9 @@ use static_init::dynamic; | |||
| use std::thread; | |||
| use substrate_cli_test_utils::*; | |||
|
|
|||
| /// Create a websocket client with a 30s timeout. | |||
| /// Create a websocket client with a 120s timeout. | |||
There was a problem hiding this comment.
So the node takes more than 30s to serve the rpc endpoint? I thought the issue was with the overall test taking more than 30s
There was a problem hiding this comment.
Nope. It was failing here. Nextest allots 2x60s before it kills you. Kitchensink in debug mode has a long startup time and this is where the time is spent AFAIK.
xermicus
approved these changes
Nov 21, 2024
alvicsam
approved these changes
Nov 21, 2024
Krayt78
pushed a commit
to Krayt78/polkadot-sdk
that referenced
this pull request
Dec 18, 2024
The eth RPC tests fail sometimes because they run into a connect timeout because the node takes a long time to start. This bumps the connect timeout from 30 to 120 seconds. Locally they take around 40s for me. As a drive by I also remove a apparently duplicated nextest config. --------- Co-authored-by: ordian <[email protected]>
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
The eth RPC tests fail sometimes because they run into a connect timeout because the node takes a long time to start. This bumps the connect timeout from 30 to 120 seconds. Locally they take around 40s for me. As a drive by I also remove a apparently duplicated nextest config. --------- Co-authored-by: ordian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eth RPC tests fail sometimes because they run into a connect timeout because the node takes a long time to start. This bumps the connect timeout from 30 to 120 seconds. Locally they take around 40s for me.
As a drive by I also remove a apparently duplicated nextest config.