Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench all weekly - and fix for pallet_multisig lib #6789

Merged
merged 27 commits into from
Jan 24, 2025
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e88c85e
bench all weekly - test
mordamax Dec 7, 2024
110426f
fix artifact name
mordamax Dec 7, 2024
7526bba
Update bench-update-weights.yml
mordamax Dec 8, 2024
b744c35
Update bench-update-weights.yml
mordamax Dec 8, 2024
9b2ce6c
Update bench-update-weights.yml
mordamax Dec 8, 2024
a23577a
Update bench-update-weights.yml
mordamax Dec 8, 2024
74bbdda
apply real bench
mordamax Dec 8, 2024
735ee8d
Update bench-update-weights.yml
mordamax Dec 8, 2024
0ac4002
increase timeout
mordamax Dec 8, 2024
81841a5
add auth
mordamax Dec 9, 2024
1bc4f70
merge master
mordamax Dec 9, 2024
d1ace92
Update bench-update-weights-weekly.yml
mordamax Dec 9, 2024
52d811a
Merge branch 'master' into mak-weekly-bench
mordamax Jan 16, 2025
10dbef2
Merge branch 'master' into mak-weekly-bench
mordamax Jan 17, 2025
f5171a4
switch to workflow_dispatch
mordamax Jan 17, 2025
c1323a8
rename workflow
mordamax Jan 17, 2025
2d4ea30
Merge branch 'master' into mak-weekly-bench
mordamax Jan 17, 2025
3115a27
go
mordamax Jan 17, 2025
a1cca9f
workflow_dispatch, --unidiff-zero
mordamax Jan 21, 2025
f6f51be
Update from mordamax running command 'bench --runtime dev --pallet pa…
Jan 21, 2025
0a6cc41
Update lib.rs
mordamax Jan 22, 2025
9b781e2
Update from mordamax running command 'bench --pallet pallet_multisig'
Jan 22, 2025
113a5a1
fix weights 2 args
mordamax Jan 22, 2025
f2962f3
Update from mordamax running command 'bench --pallet pallet_multisig …
github-actions[bot] Jan 23, 2025
3b644ec
Simplify Multisig benchmark
ggwpez Jan 23, 2025
6a93c44
Update from mordamax running command 'bench --pallet pallet_multisig …
github-actions[bot] Jan 23, 2025
4adc661
remove 2nd param
mordamax Jan 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib.rs
  • Loading branch information
mordamax committed Jan 22, 2025
commit 0a6cc4191731043cd7dc35cb911a7390434c82c4
7 changes: 4 additions & 3 deletions substrate/frame/multisig/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,9 @@ pub mod pallet {
#[pallet::weight({
let s = other_signatories.len() as u32;

T::WeightInfo::approve_as_multi_create(s)
.max(T::WeightInfo::approve_as_multi_approve(s))
// 0 to make it compile
T::WeightInfo::approve_as_multi_create(s, 0)
.max(T::WeightInfo::approve_as_multi_approve(s, 0))
.saturating_add(*max_weight)
})]
pub fn approve_as_multi(
Expand Down Expand Up @@ -453,7 +454,7 @@ pub mod pallet {
/// - I/O: 1 read `O(S)`, one remove.
/// - Storage: removes one item.
#[pallet::call_index(3)]
#[pallet::weight(T::WeightInfo::cancel_as_multi(other_signatories.len() as u32))]
#[pallet::weight(T::WeightInfo::cancel_as_multi(other_signatories.len() as u32, 0))]
ggwpez marked this conversation as resolved.
Show resolved Hide resolved
pub fn cancel_as_multi(
origin: OriginFor<T>,
threshold: u16,
Expand Down
Loading