Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6604 #6952

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6604 into stable2409 from bkchr.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6604-to-stable2409
git worktree add --checkout .worktree/backport-6604-to-stable2409 backport-6604-to-stable2409
cd .worktree/backport-6604-to-stable2409
git reset --hard HEAD^
git cherry-pick -x c10e25aaa8b8afd8665b53f0a0b02e4ea44caa77
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 18, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7934615

@EgorPopelyaev
Copy link
Contributor

@bkchr could you please check if this PR is needed in this branch (same as in stable2407) and if so resolve the conflicts?

@bkchr bkchr marked this pull request as ready for review January 14, 2025 21:16
@bkchr bkchr requested review from athei, pgherveou and a team as code owners January 14, 2025 21:16
@bkchr
Copy link
Member

bkchr commented Jan 14, 2025

@EgorPopelyaev done :)

@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 14, 2025 21:16
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Cargo.toml Outdated Show resolved Hide resolved
@EgorPopelyaev EgorPopelyaev merged commit 2afc17f into stable2409 Jan 15, 2025
148 of 186 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6604-to-stable2409 branch January 15, 2025 07:42
@EgorPopelyaev
Copy link
Contributor

Thank you!:)

bkchr added a commit that referenced this pull request Jan 23, 2025
EgorPopelyaev pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants