Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ranked collective members below mininum required rank to vote but with zero weight #6991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abdbee
Copy link

@abdbee abdbee commented Dec 23, 2024

This PR adjusts the ranked_collective pallet to allow ranked collective members below the minimum required rank to vote. But this vote doesn't affect the outcome of a poll because it carries zero weight (0 voting power).

Currently, a vote by members below the minimum rank results in a RankTooLow error. This PR removes this error and allows such members to vote successfully. This means Tally.bare_ayes increases by one for such members, but no changes are made to Ayes/Nays

This PR also extends Tally to include both out_of_rank_ayes and out_of_rank_nays for tracking votes of members below the minimum rank

This PR is a replacement for PR 3461, which I had to abandon because a little security mishap required me to re-write that PRs history and force-push.

Implements the feature discussed in #3210.

Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a migration of pallet referenda and pallet ranked collective if there is an on-going referenda?

@bkchr
Copy link
Member

bkchr commented Dec 29, 2024

ranked-collective for sure needs a migration. For referenda, we need to check if it consumes one of the changed types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants