Optimistic Project Funding #6994
Draft
+1,161
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Dec 29, 2024
substrate/frame/opf/src/types.rs
Outdated
Comment on lines
20
to
44
| pub use super::*; | ||
|
|
||
| pub use frame_support::{ | ||
| pallet_prelude::*, | ||
| traits::{ | ||
| fungible, | ||
| fungible::{Inspect, Mutate, MutateHold}, | ||
| fungibles, | ||
| schedule::{ | ||
| v3::{Anon as ScheduleAnon, Named as ScheduleNamed}, | ||
| DispatchTime, MaybeHashed, | ||
| }, | ||
| tokens::{Precision, Preservation}, | ||
| Bounded, DefensiveOption, EnsureOrigin, LockIdentifier, OriginTrait, QueryPreimage, | ||
| StorePreimage, | ||
| }, | ||
| transactional, PalletId, Serialize, | ||
| }; | ||
| pub use pallet_conviction_voting::Conviction; | ||
| pub use frame_system::{pallet_prelude::*, RawOrigin}; | ||
| pub use scale_info::prelude::vec::Vec; | ||
| pub use sp_runtime::traits::{ | ||
| AccountIdConversion, BlockNumberProvider, Convert, Dispatchable, Saturating, StaticLookup, Zero, | ||
| }; | ||
| pub use sp_std::boxed::Box; |
There was a problem hiding this comment.
why do we reexport all those types publicly, I think the doc would be more clear if we only export the types specific for the library.
Comment on lines
+19
to
+24
| pub trait Config: frame_system::Config { | ||
| type RuntimeCall: Parameter | ||
| + Dispatchable<RuntimeOrigin = Self::RuntimeOrigin> | ||
| + From<Call<Self>> | ||
| + IsType<<Self as frame_system::Config>::RuntimeCall> | ||
| + From<frame_system::Call<Self>>; |
There was a problem hiding this comment.
we no longer need to introduce a new associated type, you can bound those additional constraint direclty on the system::Config::RuntimeCall
Suggested change
| pub trait Config: frame_system::Config { | |
| type RuntimeCall: Parameter | |
| + Dispatchable<RuntimeOrigin = Self::RuntimeOrigin> | |
| + From<Call<Self>> | |
| + IsType<<Self as frame_system::Config>::RuntimeCall> | |
| + From<frame_system::Call<Self>>; | |
| pub trait Config: frame_system::Config<RuntimeCall: From<Call<Self>> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to this issue .
Through the introduction of the OPF pallet and the DISTRIBUTION pallet, we are handling the Optimistic Project Funding.
It allows users to nominate projects (whitelisted in OpenGov) with their DOT. This mechanism will be funded with a constant stream of DOT taken directly from inflation and distributed to projects based on the proportion of DOT that has nominated them.
Integration
Review Notes
Terminology
The constants available in the runtime for the OPF Pallet:
Spends.Functions
register_project: Register by OpenGov, should take AccountId and project Purpose.unregister_project: Unregister by OpenGovclaim: To claim a spendChecklist
pallet-opf