Fix transaction extension for tuple of tuples or other nested structure. #7023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a new method in the
TransactionExtension
trait:fn validate_pipeline
.This method is similar as
fn validate
but with 3 arguments for implication:inherited_tx_implication
: The implication not part of the transaction extensions. E.g. the call and the version of the transaction.inherited_tx_ext_explicit_implication
: The explicit implications of the transaction extensions in the pipeline.inherited_tx_ext_implicit_implication
: The implicit implications of the transaction extensions in the pipeline.This allows tuple to forward implication correctly, making
(A, B, C)
equivalent to(A, (B, C))
.I think this is better than having tuple compiling but still breaking user interface silently.
An alternative would be #6571 : a new struct that allow to have long pipeline. But people using tuple would still make the implication order broken.