Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix networking-benchmarks #7036

Merged
merged 5 commits into from
Jan 3, 2025
Merged

[WIP] Fix networking-benchmarks #7036

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d512ea4
[WIP] Fix networking-benchmarks
alvicsam Jan 3, 2025
15da5b9
rename file, decrease timeout
alvicsam Jan 3, 2025
2cc1c09
timeout
alvicsam Jan 3, 2025
f0e5d3c
rm debug
alvicsam Jan 3, 2025
4677d7f
rename benchmarks workflows
alvicsam Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 38 additions & 34 deletions .github/workflows/networking-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
branches:
- master
pull_request:
types: [opened, synchronize, reopened, ready_for_review]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand All @@ -27,12 +29,8 @@ jobs:
matrix:
features:
[
{
bench: "notifications_protocol",
},
{
bench: "request_response_protocol",
},
{ bench: "notifications_protocol" },
{ bench: "request_response_protocol" },
]
steps:
- name: Checkout
Expand All @@ -54,8 +52,8 @@ jobs:
publish-benchmarks:
timeout-minutes: 60
needs: [build]
if: github.ref == 'refs/heads/master'
environment: subsystem-benchmarks
# if: github.ref == 'refs/heads/master'
# environment: subsystem-benchmarks
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -69,7 +67,13 @@ jobs:
- name: Download artifacts
uses: actions/[email protected]
with:
name: networking-bench-${{ github.sha }}
name: notifications_protocol-${{ github.sha }}
path: ./charts

- name: Download artifacts
uses: actions/[email protected]
with:
name: request_response_protocol-${{ github.sha }}
path: ./charts

- name: Setup git
Expand All @@ -78,30 +82,30 @@ jobs:
git config --global --add safe.directory '*'
ls -lsR ./charts

- uses: actions/create-github-app-token@v1
id: app-token
with:
app-id: ${{ secrets.POLKADOTSDK_GHPAGES_APP_ID }}
private-key: ${{ secrets.POLKADOTSDK_GHPAGES_APP_KEY }}
# - uses: actions/create-github-app-token@v1
# id: app-token
# with:
# app-id: ${{ secrets.POLKADOTSDK_GHPAGES_APP_ID }}
# private-key: ${{ secrets.POLKADOTSDK_GHPAGES_APP_KEY }}

- name: Generate ${{ env.BENCH }}
env:
BENCH: notifications_protocol
uses: benchmark-action/github-action-benchmark@v1
with:
tool: "cargo"
output-file-path: ./charts/${{ env.BENCH }}.txt
benchmark-data-dir-path: ./bench/${{ env.BENCH }}
github-token: ${{ steps.app-token.outputs.token }}
auto-push: true
# - name: Generate ${{ env.BENCH }}
# env:
# BENCH: notifications_protocol
# uses: benchmark-action/github-action-benchmark@v1
# with:
# tool: "cargo"
# output-file-path: ./charts/${{ env.BENCH }}.txt
# benchmark-data-dir-path: ./bench/${{ env.BENCH }}
# github-token: ${{ steps.app-token.outputs.token }}
# auto-push: true

- name: Generate ${{ env.BENCH }}
env:
BENCH: request_response_protocol
uses: benchmark-action/github-action-benchmark@v1
with:
tool: "cargo"
output-file-path: ./charts/${{ env.BENCH }}.txt
benchmark-data-dir-path: ./bench/${{ env.BENCH }}
github-token: ${{ steps.app-token.outputs.token }}
auto-push: true
# - name: Generate ${{ env.BENCH }}
# env:
# BENCH: request_response_protocol
# uses: benchmark-action/github-action-benchmark@v1
# with:
# tool: "cargo"
# output-file-path: ./charts/${{ env.BENCH }}.txt
# benchmark-data-dir-path: ./bench/${{ env.BENCH }}
# github-token: ${{ steps.app-token.outputs.token }}
# auto-push: true
Loading