Remove pallet::getter usage from pallet-nft-fractionalization
#7124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
ggwpez
reviewed
Jan 14, 2025
ggwpez
approved these changes
Jan 14, 2025
bkchr
reviewed
Jan 14, 2025
| @@ -159,7 +159,6 @@ pub mod pallet { | |||
|
|
|||
| /// Keeps track of the corresponding NFT ID, asset ID and amount minted. | |||
| #[pallet::storage] | |||
| #[pallet::getter(fn nft_to_asset)] | |||
There was a problem hiding this comment.
Where is the explicit implementation of this?
There was a problem hiding this comment.
It is not required since the storage item is public
There was a problem hiding this comment.
can we make a deprecate function with a deprecate message that link to the storage get call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3326
As per title,
pallet::getterusage has been removed frompallet-nft-fractionalization.