Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Backport #7133: Sufix litep2p to the identify agent version for visibility #7153

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #7133 into stable2412 from lexnv.

See the documentation on how to use this bot.

…7133)

This PR adds the `(litep2p)` suffix to the agent version (user agent) of
the identify protocol.

The change is needed to gain visibility into network backends and
determine exactly the number of validators that are running litep2p.
Using tools like subp2p-explorer, we can determine if the validators are
running litep2p nodes.

This reflects on the identify protocol:

```
info=Identify {
  protocol_version: Some("/substrate/1.0"),
  agent_version: Some("polkadot-parachain/v1.17.0-967989c5d94 (kusama-node-name-01) (litep2p)")
  ...
}
```

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
(cherry picked from commit 105c5b9)
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@lexnv lexnv changed the title [stable2412] Backport #7133 [stable2412] Backport #7133: Sufix litep2p to the identify agent version for visibility Jan 14, 2025
@lexnv lexnv requested a review from EgorPopelyaev January 14, 2025 14:32
@EgorPopelyaev
Copy link
Contributor

@lexnv Could you please double check failing tests here: https://github.com/paritytech/polkadot-sdk/actions/runs/12769477397?pr=7153
If this is fine, I'll merge the pr

@lexnv
Copy link
Contributor

lexnv commented Jan 14, 2025

I had a look over the tests, they fail to compile because of an unexpected flag bandersnatch-experimental

 error: unexpected `cfg` condition value: `bandersnatch-experimental`
  --> substrate/primitives/core/src/lib.rs:73:7
   |
73 | #[cfg(feature = "bandersnatch-experimental")]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This seems unrelated with the changes here, maybe there was a prior backport that missed this?

Feel free to merge 🙏

@EgorPopelyaev EgorPopelyaev merged commit 2b34f2d into stable2412 Jan 14, 2025
113 of 154 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7133-to-stable2412 branch January 14, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants