Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frame crate not use the feature experimental #7177

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jan 15, 2025

We already use it for lots of pallet.

Keeping it feature gated by experimental means we lose the information of which pallet was using experimental before the migration to frame crate usage.

We can consider polkadot-sdk-frame crate unstable but let's not use the feature experimental.

@gui1117 gui1117 requested a review from a team as a code owner January 15, 2025 11:06
@gui1117
Copy link
Contributor Author

gui1117 commented Jan 15, 2025

/cmd prdoc --audience runtime_dev --bump minor

@gui1117 gui1117 added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 15, 2025
prdoc/pr_7177.prdoc Outdated Show resolved Hide resolved
@gui1117 gui1117 changed the title Make frame crate not experimental Make frame crate not use the feature experimental Jan 15, 2025
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the feature from the Cargo.toml file and its usage everywhere. Otherwise this pr is not complete.

@re-gius
Copy link
Contributor

re-gius commented Jan 15, 2025

We should remove the feature from the Cargo.toml file and its usage everywhere. Otherwise this pr is not complete.

Yes! You can find the merged PRs (and so the affected pallets) at #6504

@gui1117 gui1117 requested a review from a team as a code owner January 16, 2025 00:59
@gui1117
Copy link
Contributor Author

gui1117 commented Jan 16, 2025

We should remove the feature from the Cargo.toml file and its usage everywhere. Otherwise this pr is not complete.

Yes, I removed usages of experimental when not needed in some crates and also in doc.

About removing the feature in frame crate itself, I think we can keep it, I agree it is not good that the feature will get enabled everywhere if one dependency enables it. One way to solve this would be to also have a disable_experimental feature which would check at compilation that the feature is not enabled.

Maybe instead of feature we should give the experimental nature in the type name like UnstableMaybeConsideration instead of MaybeConsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants