Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport/stable2412: litep2p: Provide partial results to speedup GetRecord queries #7192

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #7099 into stable2412 from lexnv.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7099-to-stable2412
git worktree add --checkout .worktree/backport-7099-to-stable2412 backport-7099-to-stable2412
cd .worktree/backport-7099-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 77c78e1561bbe5ee0ecf414312bae82396ae6d11
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 15, 2025
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@lexnv lexnv changed the title [stable2412] Backport #7099 backport/stable2412: litep2p: Provide partial results to speedup GetRecord queries Jan 15, 2025
@lexnv lexnv marked this pull request as ready for review January 15, 2025 18:20
@lexnv
Copy link
Contributor

lexnv commented Jan 16, 2025

Testing Done

Authority discovery of 1k records took ~1 minute on my cloud machine in Kusama

Screenshot 2025-01-16 at 12 20 53

@lexnv lexnv requested a review from EgorPopelyaev January 16, 2025 10:22
@EgorPopelyaev EgorPopelyaev merged commit c36fdaa into stable2412 Jan 17, 2025
181 of 195 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7099-to-stable2412 branch January 17, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants