Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Partial backport of #6825 and #7205 #7298

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Jan 22, 2025

This is a partial backport of #6825 and #7205. Only the node-side minor changes were ported. However, this creates forward compatibility of the omni-node from 2412 with runtimes built after #6825.

@skunert skunert requested a review from a team January 22, 2025 14:25
@skunert skunert added the T0-node This PR/Issue is related to the topic “node”. label Jan 22, 2025
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 6c34aa1 into stable2412 Jan 24, 2025
166 of 195 checks passed
@EgorPopelyaev EgorPopelyaev deleted the skunert/stable-omni-backport branch January 24, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants