FungibleAdapter: change active_issuance on teleport #8060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
reviewed
Mar 27, 2025
| @@ -96,11 +96,13 @@ impl< | |||
|
|
|||
| fn accrue_checked(checking_account: AccountId, amount: Fungible::Balance) { | |||
| let ok = Fungible::mint_into(&checking_account, amount).is_ok(); | |||
| <Fungible as fungible::Unbalanced<_>>::deactivate(amount); | |||
There was a problem hiding this comment.
In case we go with this fix, we should probably consider a migration/correction for InactiveIssuance, right? - see the comment: #8055 (comment)
There was a problem hiding this comment.
I was thinking the same, the fix corrects from the point that we deploy it but leaves us with an inconsistent state due to what happened in between
There was a problem hiding this comment.
How about introducing a decorator type - similar to accrue_checked or an implementation of TransactAsset - that wraps types with deactivate/reactivate logic? This would make support for this feature more explicit. These types could be used for purposes beyond just teleports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FungibleAdapterwas missing deactivating balance when it was teleported away and reactivating it when it was teleported back into.Fixes #8055.