Fix teleport xcm types #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
approved these changes
Oct 18, 2023
|
This sounds like something that's bound to break once again, if they will remove the prefix... |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for failed teleport in Rococo faucet bot
I couldn't find any release notes regarding this change :(
just went to https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frococo-rpc.polkadot.io#/extrinsics and looked up the xcmPallet.limitedTeleportAssets method, where i saw expected types, which helped to migrate
the only difference is that all networks (westend, polkadot, kusama) except Rococo use similar types but without "Staging" prefix
Weird, but okay... if/when any other network also starts using Staging - it'd be easy to fix by adding them to condition.. still wondering how would I learn about this change in front